Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate metadata through message lifecycle #1452

Closed
herr-seppia opened this issue Aug 3, 2022 · 0 comments · Fixed by #1453
Closed

Propagate metadata through message lifecycle #1452

herr-seppia opened this issue Aug 3, 2022 · 0 comments · Fixed by #1453
Assignees
@herr-seppia
Labels
area:p2p issues related to kadcast, peer, gossip mark:testnet

Comments

@herr-seppia
Copy link
Member

Describe "Why" this is needed
In order to implement malicious node detection, dusk-blockchain phases should be aware of the message sender.
This information is already present at kadcast level, but so far it's always been ignored (the only information propagate is the received kadcast height)

Describe alternatives you've considered
N/A

Additional context
See also #1451
@herr-seppia herr-seppia added area:p2p issues related to kadcast, peer, gossip mark:testnet labels Aug 3, 2022
@herr-seppia herr-seppia self-assigned this Aug 3, 2022
herr-seppia added a commit that referenced this issue Aug 3, 2022
@herr-seppia
Propagate message metadata
76e9d83 
- Replace the current `message.Header` bytes with a structured `message.Metadata`
- Remove redundant usages of `config.KadcastInitHeader`
- Remove unused `kadcastHeight` in synchronizer

Resolves #1452
@herr-seppia herr-seppia mentioned this issue Aug 3, 2022
Merged
herr-seppia added a commit that referenced this issue Aug 8, 2022
@herr-seppia
Propagate message metadata
49012ac 
- Replace the current `message.Header` bytes with a structured `message.Metadata`
- Remove redundant usages of `config.KadcastInitHeader`

Resolves #1452
herr-seppia added a commit that referenced this issue Aug 8, 2022
@herr-seppia
Propagate message metadata
bbc400e 
- Replace the current `message.Header` bytes with a structured `message.Metadata`
- Remove redundant usages of `config.KadcastInitHeader`

Resolves #1452
herr-seppia added a commit that referenced this issue Aug 8, 2022
@herr-seppia
Propagate message metadata
3fca5b5 
- Replace the current `message.Header` bytes with a structured `message.Metadata`
- Remove redundant usages of `config.KadcastInitHeader`

Resolves #1452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@herr-seppia herr-seppia

Labels
area:p2p issues related to kadcast, peer, gossip mark:testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate message metadata dusk-network/dusk-blockchain
1 participant
@herr-seppia