Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AES instead of PoseidonCipher #108

Merged
merged 2 commits into from
May 1, 2024
Merged

Use AES instead of PoseidonCipher #108

merged 2 commits into from
May 1, 2024

Conversation

xevisalle
Copy link
Member

@xevisalle xevisalle commented Apr 30, 2024 •
edited
Loading

Resolves: #109

@xevisalle xevisalle requested review from moCello and miloszm April 30, 2024 15:22
@xevisalle xevisalle linked an issue Apr 30, 2024 that may be closed by this pull request
Use AES instead of PoseidonCipher #109
Closed
moCello
moCello approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Nice how we loose the different encryptions in the Request struct

@xevisalle xevisalle merged commit 22ca5c6 into main May 1, 2024
6 checks passed
@xevisalle xevisalle deleted the aes branch May 1, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moCello moCello moCello approved these changes

@miloszm miloszm Awaiting requested review from miloszm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use AES instead of PoseidonCipher
2 participants
@xevisalle @moCello