Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SAFE framework for sponge design #249

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Use SAFE framework for sponge design #249

merged 1 commit into from
Mar 6, 2024

Conversation

moCello
Copy link
Member

@moCello moCello commented Feb 8, 2024

Resolves: #248 #202

@moCello moCello force-pushed the mocello/safe branch 2 times, most recently from 1bf61fa to 439b243 Compare February 16, 2024 14:03
@moCello moCello force-pushed the mocello/safe branch 2 times, most recently from ef11838 to eef25c2 Compare March 6, 2024 09:22
miloszm
miloszm requested changes Mar 6, 2024
View reviewed changes
Copy link

@miloszm miloszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in object name in gadget.rs

src/hades/permutation/gadget.rs Outdated
});

// Apply Hades gadget permutation.
permute_gadget(composer, &mut i_var);
GadgetPermutaiton::new(composer).permute(&mut i_wit);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in object name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed it

@moCello
Integrate new SAFE framework
08ff42b 
This commit includes a big refactor of the code including the
introduction of a `Hash` struct for hashing different input.

Resolves #202 #248
@moCello moCello merged commit 119128a into master Mar 6, 2024
6 checks passed
@moCello moCello deleted the mocello/safe branch March 6, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xevisalle xevisalle xevisalle approved these changes

@miloszm miloszm miloszm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce new SAFE framework
3 participants
@moCello @miloszm @xevisalle