Remove the hades-constants iterator and reduce the amount of constants to 335 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moCello
force-pushed
the
mocello/246_constants
branch
6 times, most recently
from
3a47bab to
d34c587
Compare
xevisalle
approved these changes
Jan 30, 2024
moCello
force-pushed
the
mocello/246_constants
branch
from
56c7ccb to
86ea655
Compare
- Decrease amount of statically loaded constants from 960 to 335 - Change the `const ROUND_CONSTANTS` to a 2-dim array - Add compile time warning for constants generation - Remove the hades constants iterator - Rename `add_round_key` to `add_round_constants` to match the paper - Rename internal constant `TOTAL_FULL_ROUNDS` to `FULL_ROUNDS`. Resolves #246
moCello
force-pushed
the
mocello/246_constants
branch
from
86ea655 to
de34dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #246