Fix features for cipher and clippy warnings

src/cipher.rs

@@ -99,7 +99,7 @@ use bytecheck::CheckBytes;
 use rkyv::{Archive, Deserialize, Serialize};
 
 #[cfg(feature = "zk")]
-pub use zk::{decrypt, encrypt};
+pub(crate) use zk::{decrypt, encrypt};
 
 const MESSAGE_CAPACITY: usize = 2;
 const CIPHER_SIZE: usize = MESSAGE_CAPACITY + 1;

src/hash.rs

@@ -51,7 +51,7 @@ impl Domain {
 
 fn io_pattern<R: AsRef<[T]>, T>(
     domain: Domain,
-    input: &Vec<R>,
+    input: &[R],
     output_len: usize,
 ) -> Result<Vec<Call>, Error> {
     let mut io_pattern = Vec::new();
@@ -124,7 +124,7 @@ impl<R: AsRef<[BlsScalar]>> Hash<R> {
             sponge.absorb(input.as_ref().len(), input)?;
         }
         // squeeze the output
-        sponge.squeeze(self.output_len as usize)?;
+        sponge.squeeze(self.output_len)?;
 
         // return the result
         Ok(sponge.finish()?)

src/lib.rs

@@ -24,7 +24,9 @@ pub use hash::{Domain, Hash};
 #[cfg(feature = "cipher")]
 mod cipher;
 #[cfg(feature = "cipher")]
+pub use cipher::PoseidonCipher;
+#[cfg(feature = "cipher")]
+#[cfg(feature = "zk")]
 pub use cipher::{
     zk::decrypt as decrypt_gadget, zk::encrypt as encrypt_gadget,
-    PoseidonCipher,
 };