test: Addition of test cases for the Data Preprocessor code #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Co-authored-by: Will Johnson <[email protected]> Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Will Johnson <[email protected]> fmt Signed-off-by: Will Johnson <[email protected]>
…-impl-unit-fix tests: reformat `mock.patch` to inside unit tests Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Abhishek <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Will Johnson <[email protected]> fmt Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Abhishek <[email protected]>
Removes unused dead code after adding the new framework and refactors some test cases and files. Signed-off-by: Dushyant Behl <[email protected]>
data preprocessing Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Dushyant Behl <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
…pl' into data_preprocessor_dushyant Signed-off-by: Abhishek <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
Signed-off-by: Abhishek <[email protected]>
Signed-off-by: Abhishek <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
…pl' into data_preprocessor_dushyant
Signed-off-by: Will Johnson <[email protected]>
…pl' into data_preprocessor_dushyant
…PreProcessor Signed-off-by: Abhishek <[email protected]>
Signed-off-by: Abhishek <[email protected]>
|
Thanks for making a pull request! 😃 |
Signed-off-by: Abhishek <[email protected]>
willmj
reviewed
Nov 25, 2024
Comment on lines
39
to
49
| BASE_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__), "../..")) | ||
| PREDEFINED_DATA_CONFIGS = os.path.join(BASE_DIR, "examples", "predefined_data_configs") | ||
| APPLY_CUSTOM_TEMPLATE_YAML = os.path.join( | ||
| PREDEFINED_DATA_CONFIGS, "apply_custom_template.yaml" | ||
| ) | ||
| PRETOKENIZE_JSON_DATA_YAML = os.path.join( | ||
| PREDEFINED_DATA_CONFIGS, "pretokenized_json_data.yaml" | ||
| ) | ||
| TOKENIZE_AND_INSTRUCTION_MASKING_YAML = os.path.join( | ||
| PREDEFINED_DATA_CONFIGS, "tokenize_and_instruction_masking.yaml" | ||
| ) |
There was a problem hiding this comment.
Should this go in an __init__.py file like the one for tests/testdata?
There was a problem hiding this comment.
Yea make sense. Thanks Will. Pushed the refactored code.
Signed-off-by: Abhishek <[email protected]>
Signed-off-by: Will Johnson <[email protected]>
…pl' into data_preprocessor_dushyant Signed-off-by: Abhishek <[email protected]>
dushyantbehl
force-pushed
the
dataloader-v2-impl
branch
3 times, most recently
from
826463f
to
e045ca7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Addition of unit test cases for function: load_dataset and function _process_dataconfig_file
Related issue number
https://github.ibm.com/ai-foundation/watson-fm-stack-tracker/issues/1428
How to verify the PR
Running test cases
Was the PR tested