Update models.rdf #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove subPropertyOf for ldp:contains to avoid weirdness with resources being contained by two containers. Add hasRelatedObject predicate.
|
@azaroth42, is this update contentious with respect to the recent email thread: |
|
Yes, replied in the thread with expanded rationale. :) |
| <rdfs:isDefinedBy rdf:resource="http://pcdm.org/models#"/> | ||
| </rdf:Property> | ||
|
|
||
| <rdf:Property rdf:about="http://pcdm.org/models#hasRelatedObject"> |
There was a problem hiding this comment.
Do we still want hsaRelatedObject? Aren't we using ore:aggregates instead?
There was a problem hiding this comment.
I think having hasRelatedObject explicitly defined is better than using ore:aggregates directly (even if the domain and range are the same), since it lets us call out the specific semantics we intend.
|
👍 -- I think this is better than #6 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove subPropertyOf for ldp:contains to avoid weirdness with resources being contained by two containers.
Add hasRelatedObject predicate.