Add proxy server support #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yizshi
reviewed
Oct 30, 2023
duo-universal-sdk/src/main/java/com/duosecurity/service/DuoConnector.java
Show resolved
Hide resolved
duo-universal-sdk/src/main/java/com/duosecurity/service/DuoConnector.java
Outdated
Show resolved
Hide resolved
yizshi
reviewed
Oct 31, 2023
duo-universal-sdk/src/main/java/com/duosecurity/service/DuoConnector.java
Show resolved
Hide resolved
duo-universal-sdk/src/main/java/com/duosecurity/service/DuoConnector.java
Outdated
Show resolved
Hide resolved
Restore code to display response.errorBody if it's not null.
yizshi
reviewed
Oct 31, 2023
duo-universal-sdk/src/test/java/com/duosecurity/service/DuoConnectorTest.java
Outdated
Show resolved
Hide resolved
Restore exception message format to match the format in the exchangeAuthorizationCodeFor2FAResult_error_code test.
yizshi
approved these changes
Oct 31, 2023
You're welcome and thank you so much for your review and help to get this added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add http proxy server support
Motivation and Context
These updates allow a Client to be created that routes requests through an http proxy server.
This will resolve issue #12
How Has This Been Tested?
This was tested using our organizations proxy server to successfully connect to an application created in our Duo account. A new test was not added as connecting through a live proxy server is organization dependent.
Types of Changes