Update serialization to use System.Text.Json (#32) #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the API Client to use the modern
System.Text.Json
rather thanSystem.Web.Script.Serialization
as an initial step to modernize the library with an upgrade to net standard and / or the latest runtime, resolving #32 .Motivation and Context
Resolve issue #32 and remove a blocker to targeting a more modern .NET runtime.
How Has This Been Tested?
In addition to ensuring unit tests still pass, I also ran the example program against a test Admin API. I inspected each of the data types returned in the resulting dictionary to verify that they have not changed between master and this branch, which is the biggest risk of this change as the payloads of various API endpoints aren't defined with formal types, just the generic dictionary.
Types of Changes