Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serialization to use System.Text.Json (#32) #34

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

jamdavil
Copy link
Contributor

Description

This PR updates the API Client to use the modern System.Text.Json rather than System.Web.Script.Serialization as an initial step to modernize the library with an upgrade to net standard and / or the latest runtime, resolving #32 .

Motivation and Context

Resolve issue #32 and remove a blocker to targeting a more modern .NET runtime.

How Has This Been Tested?

In addition to ensuring unit tests still pass, I also ran the example program against a test Admin API. I inspected each of the data types returned in the resulting dictionary to verify that they have not changed between master and this branch, which is the biggest risk of this change as the payloads of various API endpoints aren't defined with formal types, just the generic dictionary.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@AaronAtDuo AaronAtDuo merged commit b6d7e44 into duosecurity:master Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants