Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported to .Net standard #22

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Atrejoe
Copy link
Contributor

@Atrejoe Atrejoe commented Dec 6, 2022

Needs review.
Proxy detection has been commented out. Quite a bit of refactpring.

@mattborja
Copy link
Contributor

@Atrejoe You still working on this? Failed a couple builds there. I was going to look into it, but logs have expired.

If either of you (@AaronAtDuo) were interested, I wouldn't mind reviewing this when I get some downtime. Haven't quite gotten on the .NET Standard/Core/etc. bandwagon at work yet, but this would be a good intro for me. Figure eventually I'll move us to it, but I'm still waiting for things to stabilize (i.e. the hype to settle).

Either way, let me know. Thanks.

Replaced JsonConverter, separated parsing into predictable envelope and dynamic payload. Update
@Atrejoe Atrejoe force-pushed the feature/migrates_to_net_standard branch from ffe60a7 to f644318 Compare August 12, 2023 22:37
@Atrejoe
Copy link
Contributor Author

Atrejoe commented Aug 12, 2023

If you do, you may want to take https://github.com/Atrejoe/duo_api_csharp/tree/feature/concrete_mapped_methods as a starting point.
I just rebased it, to be ahead of this repo's master. This version has some developer-friendly concrete API call mappings. (see https://github.com/Atrejoe/duo_api_csharp/blob/feature/concrete_mapped_methods/DuoApi/DuoApiMethods.cs)

@AaronAtDuo
Copy link
Contributor

To be honest, I mainly want .NET standard/core support because I develop on Linux :)

I'll try to take a look, but my team has quite a full plate at the moment.

@AaronAtDuo
Copy link
Contributor

@Atrejoe @mattborja I wanted to mention a project our design team is working on, if you are interested:

Duo is looking to learn how to significantly improve the developer experience and what tools, resources, and technology (eg: sandboxes, new sdks, etc.) would best-enable customers to work faster and build things more easily with Duo's developer ecosystem. If your org is a Duo customer, and you have done development work (ex; authentication integrations, creation of a homegrown admin tool, log consumption for SIEMS, etc) with Duo's developer tools/resources in the past year, we would love to speak with you about your experience, what tools/resources you used, and your pain points.
This will be a 60-minute session during which you’ll have the opportunity to discuss your honest thoughts and feedback with Duo researchers. No preparation is necessary, and please know that this is not a sales call or product demo.
If you’re interested in participating, please email [email protected] to start the scheduling process.
Once the 60-minute session is complete, you will receive a token of appreciation in the form of a $75 e-gift card through Tremendous (options for Amazon or select retailers).
Please let me know if you have any questions!
Thanks!

@Atrejoe
Copy link
Contributor Author

Atrejoe commented Sep 28, 2023

I think this is not so much true failing tests (all work on my machine ™️), but a GitHub actions configuration issue that needs to be addressed in this pull request:

  • Proper version of the .Net Core build
  • Correct reference to test dll (or alternate solution) for .Net framework build

image

@AaronAtDuo
Copy link
Contributor

@Atrejoe Lillian asked me to pass this along:

Dear Robert,
I'm Lillian, a design researcher at Duo who is working with Aaron's team to better understand how Duo can significantly improve our developer experience for customer and partner developers. To double-check, is your org currently a Duo customer and/or Duo partner?

As Aaron mentioned in his Github message, we'd like to talk with anyone who has done development work (ex; authentication integrations, creation of a homegrown admin tool, log consumption for SIEMS, etc) with Duo's developer tools (i.e., APIs, webSDKs, OIDC) and resources (ex; API clients, docs), preferably in the past year. The topics will be: what Duo projects you've built, the steps you took in your development journey and how Duo could better support you, and what tools/resources you used and their pain points.

If these sound like topics that you would like to speak on, here is the scheduling link.
Let me know if you have any other questions,
Lillian Li

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants