-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add async support for csv and dataframe methods #56
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
im a bit out of depth here. in the basic client, the
however, the
but is this really the most efficient way to convert the asynchronous response to something pandas can read? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this looks excellent, really nice job here. I wish there was some way to reduce the overall duplication between the two clients, but I guess not. I have never actually used the async variant and wonder if anyone out there is...
Anyway, this looks great to me!
I would be willing to merge as is and we can tag a new release after a few other of the pending/incoming PRs are landed. Just let me know |
@eliseygusev care to comment on the async aspect here maybe? |
i will resolve conflicts and update for updates made to client in #53 |
Were you still planning on resolving conflicts here? |
yes will do, just also have a day job :( |
should be good to merge @bh2smith!
|
@bh2smith what is in the way of merging this? i think waiting will just creates more conflicts down the road for other prs... |
Ya we can merge this... but the performance tier is still failing. Its fine though (aw you explained) |
Could you also review #59 --- @gosuto-inzasheru? Then I can tag a new release. |
opening this as a draft to get some feedback.
get_result_csv
,_refresh
,refresh_csv
andrefresh_into_dataframe
client.py
andclient_async.py
, to make future maintenance easiermake test-all
passes 100%closes #54