Add Partial to QueryState Enum #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barkntuncer
reviewed
May 10, 2024
bh2smith
force-pushed
the
124/partial-fix
branch
from
108d727
to
8a60a38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124 (introducing the new execution state to the enum) and adds
allow_partial_results=trueby default on query executions. The point is so that long running queries don't fail to execute because of a parsing error. I am not sure if there were additional plans to make use of this (like showing progress bar), but generally I would say that this "closes #124".Test Plan
Existing CI -- no logical changes were made to the code.