Skip to content

Commit

Permalink
[Easy] Cleanup (#65)
Browse files Browse the repository at this point in the history
* pre-cleanup before bigger changes

* rename error in test
  • Loading branch information
bh2smith authored Sep 5, 2023
1 parent 48343d5 commit f4828da
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions dune_client/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -364,15 +364,13 @@ def unarchive_query(self, query_id: int) -> bool:
def make_private(self, query_id: int) -> None:
"""
https://dune.com/docs/api/api-reference/edit-queries/private-query
returns resulting value of Query.is_private
"""
response_json = self._post(route=f"/query/{query_id}/private")
assert self.get_query(int(response_json["query_id"])).meta.is_private

def make_public(self, query_id: int) -> None:
"""
https://dune.com/docs/api/api-reference/edit-queries/private-query
returns resulting value of Query.is_private
"""
response_json = self._post(route=f"/query/{query_id}/unprivate")
assert not self.get_query(int(response_json["query_id"])).meta.is_private
3 changes: 2 additions & 1 deletion tests/e2e/test_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def test_internal_error(self):
dune.execute(query)
self.assertEqual(
str(err.exception),
"Can't build ExecutionResponse from {'error': 'Query not found'}",
"Can't build ExecutionResponse from {'error': 'An internal error occured'}",
)

def test_invalid_job_id_error(self):
Expand All @@ -176,6 +176,7 @@ def test_get_latest_result_with_query_id(self):
self.assertGreater(len(results), 0)


@unittest.skip("This is an enterprise only endpoint that can no longer be tested.")
class TestCRUDOps(unittest.TestCase):
def setUp(self) -> None:
dotenv.load_dotenv()
Expand Down

0 comments on commit f4828da

Please sign in to comment.