Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace scripts with xtask pattern #1097

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .cargo/config.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
[alias]
xtask = "run --package xtask --"

[build]
rustflags = ["-Z", "thinlto=no", "-Z", "share-generics=y"]

Expand Down
2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Auto detect text files and perform LF normalization
* text=auto
* text=auto eol=lf


*.ts text eol=lf merge=union
Expand Down
10 changes: 4 additions & 6 deletions .github/workflows/check-stats.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,10 @@ jobs:
echo -n "Commit: " >> pr/comment.md
echo '${{ github.event.pull_request.head.sha }}' >> pr/comment.md

- run: ./scripts/auto-unignore.sh
working-directory: crates/stc_ts_file_analyzer
- run: cargo xtask auto-unignore
continue-on-error: true

- run: ./scripts/check.sh > /dev/null
working-directory: crates/stc_ts_type_checker
- run: cargo xtask test-checker > /dev/null
continue-on-error: true

- name: Write description
Expand All @@ -53,8 +51,8 @@ jobs:
echo -n 'These are files which is affected by the current PR, but not reflected. ' >> pr/comment.md
echo "If there's no file below this message, please ignore this message." >> pr/comment.md
echo '' >> pr/comment.md
echo -n 'You can run `./scripts/auto-unignore.sh` from `crates/stc_ts_file_analyzer` for typescript files, ' >> pr/comment.md
echo 'and `./scripts/check.sh` from `crates/stc_ts_type_checker` for `*.stats.rust-debug` files.' >> pr/comment.md
echo -n 'You can run `cargo xtask auto-unignore` for typescript files, ' >> pr/comment.md
echo 'and `cargo xtask test-checker` for `*.stats.rust-debug` files.' >> pr/comment.md
echo '' >> pr/comment.md

- name: Store changed files
Expand Down
2 changes: 1 addition & 1 deletion .husky/pre-push
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ set -eu
export HUSKY=1;
# We don't use this anymore
# export STC_IGNORE_WIP=1
# (cd ./typescript/type_checker && ./scripts/test.sh)
# cargo xtask file-analyzer --all
Loading
Loading