Skip to content
This repository has been archived by the owner on Mar 20, 2020. It is now read-only.

Fix Detector to correctly handle multiple tag families #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nuntipat
Copy link

@nuntipat nuntipat commented Dec 7, 2019

The detector accepts multiple tag families separated with a space. However, it's constructor only initialize one tag family even through the destructor correctly destroys every tag family specified. The new implementation uses a for loop to iterate through each tag family's name and raise exception when the invalid name is found.

@AleksandarPetrov
Copy link
Contributor

@nuntipat that's a good catch! I will need to test it and will then merge it. Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants