Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LogicalType and DataChunk to have Handle suffix #361

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

Swoorup
Copy link
Contributor

@Swoorup Swoorup commented Jul 20, 2024

More refactoring changes from #337

  • Rename LogicalType and DataChunk to have Handle suffix, as these are just reference handle to the duckdb'c api's. LogicalType and DataChunk will be used later to contain more information about the themselves.
  • Introduce DuckDbString as this need to be cleanup using a Duckdb C api. Mostly to wrap unsafe functions.
  • Use num-integer version from root manifest toml for consistency
  • Also mark functions/convert to unsafe equivalent instead of using the from trait, when getting their inner field directly from c api, to mark it as unsafe.

@Swoorup Swoorup force-pushed the sj-refactor-handles branch from fe00edd to b05c6f4 Compare July 20, 2024 14:05
@Swoorup Swoorup changed the title Rename LogicalType and DataChunk to have Handle prefix Rename LogicalType and DataChunk to have Handle suffix Jul 20, 2024
@Mytherin Mytherin merged commit 201a3d0 into duckdb:main Aug 1, 2024
4 checks passed
@Mytherin
Copy link
Contributor

Mytherin commented Aug 1, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants