Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BinaryArray in arrow-vtab #324

Merged
merged 3 commits into from
Jun 5, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
phillipleblanc committed Jun 4, 2024
commit 368d93f0e0a871aa8960ebb5a264ddea9f39d761
2 changes: 1 addition & 1 deletion src/vtab/arrow.rs
Original file line number Diff line number Diff line change
@@ -913,7 +913,7 @@ mod test {

#[test]
fn test_arrow_binary() {
let byte_array = BinaryArray::from_iter_values(vec![b"test"].iter());
let byte_array = BinaryArray::from_iter_values([b"test"].iter());
let arc: ArrayRef = Arc::new(byte_array);
let batch = RecordBatch::try_from_iter(vec![("x", arc)]).unwrap();


Unchanged files with check annotations Beta

)]
extern crate autocfg;
#[cfg(feature = "openssl_bindgen")]

Check warning on line 22 in libduckdb-sys/openssl/mod.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `openssl_bindgen`
extern crate bindgen;
extern crate cc;
#[cfg(feature = "vendored")]

Check warning on line 25 in libduckdb-sys/openssl/mod.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `vendored`
extern crate openssl_src;
extern crate pkg_config;
#[cfg(target_env = "msvc")]
mod cfgs;
mod find_normal;
#[cfg(feature = "vendored")]

Check warning on line 40 in libduckdb-sys/openssl/mod.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `vendored`
mod find_vendored;
#[cfg(feature = "openssl_bindgen")]

Check warning on line 42 in libduckdb-sys/openssl/mod.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `openssl_bindgen`
mod run_bindgen;
#[derive(PartialEq)]
}
fn find_openssl(target: &str) -> Result<(Vec<PathBuf>, PathBuf), ()> {
#[cfg(feature = "vendored")]

Check warning on line 72 in libduckdb-sys/openssl/mod.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `vendored`
{
// vendor if the feature is present, unless
// OPENSSL_NO_VENDOR exists and isn't `0`
}
fn check_ssl_kind() -> Result<(), ()> {
if cfg!(feature = "unstable_boringssl") {

Check warning on line 84 in libduckdb-sys/openssl/mod.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `unstable_boringssl`
println!("cargo:rustc-cfg=boringssl");
// BoringSSL does not have any build logic, exit early
Err(())
INCLUDE_DIR = Some(include_dirs[0].clone());
}
}
#[cfg(feature = "openssl_bindgen")]

Check warning on line 185 in libduckdb-sys/openssl/mod.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `openssl_bindgen`
run_bindgen::run(&include_dirs);
version
//! [datetime](https://www.sqlite.org/lang_datefunc.html) functions. If you
//! want different storage for datetimes, you can use a newtype.
#![cfg_attr(
feature = "time",

Check warning on line 38 in src/types/mod.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `time`
doc = r##"
For example, to store datetimes as `i64`s counting the number of seconds since
the Unix epoch:
/// If associated DB schema can be altered concurrently, you should make
/// sure that current statement has already been stepped once before
/// calling this method.
#[cfg(feature = "column_decltype")]

Check warning on line 127 in src/column.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `column_decltype`
pub fn columns(&self) -> Vec<Column> {
let n = self.column_count();
let mut cols = Vec::with_capacity(n as usize);
use crate::{Connection, Result};
#[test]
#[cfg(feature = "column_decltype")]

Check warning on line 147 in src/column.rs

GitHub Actions / Address Sanitizer

unexpected `cfg` condition value: `column_decltype`
fn test_columns() -> Result<()> {
use super::Column;