Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the ArrowVTab module public #259

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Make the ArrowVTab module public #259

merged 7 commits into from
Mar 29, 2024

Conversation

phillipleblanc
Copy link
Contributor

I assume from the comment in this issue that the ArrowVTab module was intended to be made public. This PR makes it public so that consumers can actually use it.

I've tested this code in my fork and it works great.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d48b967) 60.55% compared to head (799e70a) 60.50%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   60.55%   60.50%   -0.05%     
==========================================
  Files          36       36              
  Lines        2132     2132              
==========================================
- Hits         1291     1290       -1     
- Misses        841      842       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mytherin Mytherin merged commit ff7d11d into duckdb:main Mar 29, 2024
4 checks passed
@Mytherin
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants