Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct generated function name #245

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

Mause
Copy link
Member

@Mause Mause commented Dec 29, 2023

Just a small fix for the function generation macro

@Mause Mause requested a review from wangfenjin December 29, 2023 12:34
remove dud enumerate call
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b412f69) 59.23% compared to head (70f490e) 59.36%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   59.23%   59.36%   +0.12%     
==========================================
  Files          36       36              
  Lines        2100     2104       +4     
==========================================
+ Hits         1244     1249       +5     
+ Misses        856      855       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mause Mause requested a review from Mytherin January 2, 2024 05:33
@Mytherin Mytherin merged commit 897cd67 into duckdb:main Jan 2, 2024
4 checks passed
@Mytherin
Copy link
Contributor

Mytherin commented Jan 2, 2024

Thanks!

@Mause Mause deleted the extension-version-function-name branch January 2, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants