Skip to content

Commit

Permalink
Keep other feature configuration from openssl
Browse files Browse the repository at this point in the history
  • Loading branch information
Murali committed Jun 3, 2024
1 parent 2a879d4 commit de4fad3
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 7 deletions.
4 changes: 3 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ bundled = ["libduckdb-sys/bundled"]
httpfs = ["libduckdb-sys/httpfs", "bundled"]
json = ["libduckdb-sys/json", "bundled"]
parquet = ["libduckdb-sys/parquet", "bundled"]
vendored = ["libduckdb-sys/vendored", "bundled"]
openssl_vendored = ["libduckdb-sys/openssl_vendored", "bundled"]
unstable_boringssl = ["libduckdb-sys/unstable_boringssl", "bundled"]
openssl_bindgen = ["libduckdb-sys/openssl_bindgen", "bundled"]
vtab = []
vtab-loadable = ["vtab", "duckdb-loadable-macros"]
vtab-excel = ["vtab", "calamine"]
Expand Down
4 changes: 3 additions & 1 deletion libduckdb-sys/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ httpfs = ["bundled"]
json = ["bundled"]
parquet = ["bundled"]
extensions-full = ["httpfs", "json", "parquet"]
vendored = ["openssl-src"]
openssl_vendored = ["bundled", "openssl-src"]
openssl_bindgen = ["bundled", "bindgen", "pkg-config", "vcpkg"]
unstable_boringssl = ["bundled"]

[dependencies]

Expand Down
2 changes: 1 addition & 1 deletion libduckdb-sys/openssl/find_normal.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ openssl-sys = {}
openssl-sys crate build failed: no supported version of OpenSSL found.
Ways to fix it:
- Use the `vendored` feature of openssl-sys crate to build OpenSSL from source.
- Use the `openssl_vendored` feature of libduckdb-sys crate to build OpenSSL from source.
- Use Homebrew to install the `openssl` package.
",
Expand Down
2 changes: 1 addition & 1 deletion libduckdb-sys/openssl/find_vendored.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use std::path::PathBuf;

pub fn get_openssl(_target: &str) -> (Vec<PathBuf>, PathBuf) {
let artifacts = openssl_src::Build::new().build();
println!("cargo:vendored=1");
println!("cargo:openssl_vendored=1");
println!("cargo:root={}", artifacts.lib_dir().parent().unwrap().display());

(
Expand Down
6 changes: 3 additions & 3 deletions libduckdb-sys/openssl/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ extern crate autocfg;
#[cfg(feature = "openssl_bindgen")]
extern crate bindgen;
extern crate cc;
#[cfg(feature = "vendored")]
#[cfg(feature = "openssl_vendored")]
extern crate openssl_src;
extern crate pkg_config;
#[cfg(target_env = "msvc")]
Expand All @@ -37,7 +37,7 @@ use std::{
mod cfgs;

mod find_normal;
#[cfg(feature = "vendored")]
#[cfg(feature = "openssl_vendored")]
mod find_vendored;
#[cfg(feature = "openssl_bindgen")]
mod run_bindgen;
Expand Down Expand Up @@ -69,7 +69,7 @@ fn env(name: &str) -> Option<OsString> {
}

fn find_openssl(target: &str) -> Result<(Vec<PathBuf>, PathBuf), ()> {
#[cfg(feature = "vendored")]
#[cfg(feature = "openssl_vendored")]
{
// vendor if the feature is present, unless
// OPENSSL_NO_VENDOR exists and isn't `0`
Expand Down

0 comments on commit de4fad3

Please sign in to comment.