Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Add head http method. #17

Merged
merged 8 commits into from
Feb 7, 2021
Merged

Conversation

plombard
Copy link
Contributor

@plombard plombard commented Feb 6, 2021

Hello, I was looking for a drop-in replacement for httpie, which is fantastic but add a 300ms overhead to every request on my work machine, and I think ht should be ideal for helping me develop my APIs. I use HEAD endpoints in my APIs so I needed this method included. I'm not a seasoned Rust developer so it may not be perfect code.

@ducaale
Copy link
Owner

ducaale commented Feb 6, 2021

Thanks, @plombard. It seems this PR is overlapping with another PR that is adding support for the HEAD HTTP method. Maybe you could update this PR to support the OPTIONS method instead? Thanks again.

@plombard
Copy link
Contributor Author

plombard commented Feb 6, 2021

Sure, I'll give it a try.

tests/cli.rs Outdated Show resolved Hide resolved
Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nitpick. Other than that, everything looks good.

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@ducaale ducaale merged commit 4c11c6e into ducaale:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants