Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading args from a config file #165

Merged
merged 11 commits into from
Aug 2, 2021
Merged

Support reading args from a config file #165

merged 11 commits into from
Aug 2, 2021

Conversation

ducaale
Copy link
Owner

@ducaale ducaale commented Aug 2, 2021

Ticks another item from #4.

Also, see https://httpie.io/docs#configurable-options

@ducaale ducaale mentioned this pull request Aug 2, 2021
28 tasks
src/cli.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/printer.rs Show resolved Hide resolved
src/cli.rs Show resolved Hide resolved
@ducaale ducaale marked this pull request as ready for review August 2, 2021 17:37
@ducaale ducaale requested a review from blyxxyz August 2, 2021 19:41
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ducaale ducaale merged commit 7b958dd into master Aug 2, 2021
@ducaale ducaale deleted the default-options branch August 2, 2021 20:58
@blyxxyz
Copy link
Collaborator

blyxxyz commented Aug 2, 2021

Should this have gone into master?

@ducaale ducaale restored the default-options branch August 2, 2021 21:30
@ducaale
Copy link
Owner Author

ducaale commented Aug 2, 2021

Nope, I will revert the recent changes on master and merge to develop instead 👍

Edit: Done, thanks for catching my mistake 😬

@ducaale ducaale deleted the default-options branch August 2, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants