Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading DataField and JsonField value from a file #118

Merged
merged 11 commits into from
Mar 29, 2021
Merged

Support reading DataField and JsonField value from a file #118

merged 11 commits into from
Mar 29, 2021

Conversation

ducaale
Copy link
Owner

@ducaale ducaale commented Mar 29, 2021

Ticks one more item from #4

@ducaale
Copy link
Owner Author

ducaale commented Mar 29, 2021 •
edited
Loading

I need to update man.roff to mention the new RequestItem types i.e =@ and :=@

@ducaale ducaale changed the title Support reading DataField and JsonField value from file Support reading DataField and JsonField value from a file Mar 29, 2021
blyxxyz
blyxxyz requested changes Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Maybe there should be a few integration tests?

src/request_items.rs Outdated Show resolved Hide resolved
src/request_items.rs Outdated Show resolved Hide resolved
src/request_items.rs Outdated Show resolved Hide resolved
blyxxyz
blyxxyz reviewed Mar 29, 2021
View reviewed changes
src/to_curl.rs Outdated Show resolved Hide resolved
blyxxyz
blyxxyz approved these changes Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ducaale ducaale merged commit 2e4b169 into develop Mar 29, 2021
@ducaale ducaale deleted the more-seperators branch March 29, 2021 20:40
@ducaale ducaale mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxxyz blyxxyz blyxxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ducaale @blyxxyz