Block reward validation #1093
Merged
Block reward validation #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Concept ACK, reviewing in greater detail |
Nizametdinov
commented
May 10, 2019
| } | ||
|
|
||
| // TODO UNIT-E: make the check stricter: if (output_amount - input_amount < total_reward) | ||
| if (output_amount - input_amount < total_reward - fees) { |
There was a problem hiding this comment.
This check allows proposers to burn fees.
Ruteri
reviewed
May 13, 2019
Nizametdinov
force-pushed
the
block-reward-validation
branch
from
a01e0ea
to
d7f6bca
Compare
Ruteri
reviewed
May 14, 2019
Ruteri
reviewed
May 14, 2019
|
utACK 5651db0 |
scravy
approved these changes
May 14, 2019
Signed-off-by: Azat Nizametdinov <[email protected]>
Signed-off-by: Azat Nizametdinov <[email protected]>
Signed-off-by: Azat Nizametdinov <[email protected]>
Signed-off-by: Azat Nizametdinov <[email protected]>
Signed-off-by: Azat Nizametdinov <[email protected]>
Signed-off-by: Azat Nizametdinov <[email protected]>
Nizametdinov
force-pushed
the
block-reward-validation
branch
from
5651db0
to
1a7c4f8
Compare
dsaveliev
approved these changes
May 15, 2019
Gnappuraz
reviewed
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #777.
Extracted from #1081 because it contains important changes to coinbase validation which can be easily overlooked.
This PR implements the following rules for coinbase transactions:
Note that the first output (which is subject to coinbase maturity) can be bigger than the block reward plus fees, i.e. the reward and the stake can be sent to one output. It might useful for proposers who do not want to increase the number of their coins.