Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GetEpoch, IsEpochStart, and IsCheckpoint to finalization::Params #1087

Merged
merged 1 commit into from
May 9, 2019
Merged

Move GetEpoch, IsEpochStart, and IsCheckpoint to finalization::Params #1087

merged 1 commit into from
May 9, 2019

Conversation

Nizametdinov
Copy link
Member

GetEpoch, IsEpochStart, and IsCheckpoint do not depend on the finalization state and hence should be moved to finalization::Params.

Extracted from #1081.

@Nizametdinov Nizametdinov added the refactoring Changes which clean up code but don't change the user-visible behavior label May 8, 2019
@Nizametdinov Nizametdinov self-assigned this May 8, 2019
@Gnappuraz Gnappuraz self-requested a review May 9, 2019 08:28
Gnappuraz
Gnappuraz approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@Gnappuraz Gnappuraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! utACK d8b094e

Ruteri
Ruteri approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d8b094e

kostyantyn
kostyantyn approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@kostyantyn kostyantyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d8b094e

@Nizametdinov Nizametdinov merged commit 057ac30 into dtr-org:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostyantyn kostyantyn kostyantyn approved these changes

@Gnappuraz Gnappuraz Gnappuraz approved these changes

@Ruteri Ruteri Ruteri approved these changes

@frolosofsky frolosofsky Awaiting requested review from frolosofsky

Assignees

@Nizametdinov Nizametdinov

Labels
refactoring Changes which clean up code but don't change the user-visible behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nizametdinov @kostyantyn @Gnappuraz @Ruteri