Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #1514 MADIS2NC wrapper #2591

Merged
merged 17 commits into from
May 17, 2024
Merged

Feature #1514 MADIS2NC wrapper #2591

merged 17 commits into from
May 17, 2024

Commits on May 15, 2024

  1. Per #1514, implement MADIS2NC wrapper and added example use case. Als… 

    …o updated the function to handle the time_summary dictionary in MET config files to support names that exactly match the name found in the dictionary, e.g. ASCII2NC_TIME_SUMMARY_OBS_VAR sets time_summary.obs_var (previously only ASCII2NC_TIME_SUMMARY_VAR_NAMES was supported and is still supported)
    @georgemccabe
    georgemccabe committed May 15, 2024
    Configuration menu
    Copy the full SHA
    c1f79b4 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. remove execute permissions from image files

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f16f97e View commit details
    Browse the repository at this point in the history

  2. Per #1514, add image for basic use case

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    efa852e View commit details
    Browse the repository at this point in the history

  3. removed large image files that are no longer being used in documentation

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    af4cee2 View commit details
    Browse the repository at this point in the history

  4. merged develop and resolved conflicts

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ea3feba View commit details
    Browse the repository at this point in the history

  5. add support for time_offset_warning for MADIS2NC wrapper after the PR… 

    … to add that support for other wrappers has been merged into develop
    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    a9e6bec View commit details
    Browse the repository at this point in the history

  6. report error if output template is not defined

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    dec497a View commit details
    Browse the repository at this point in the history

  7. update contributor's guide with more up-to-date info on how to create… 

    … a new wrapper and basic components of wrappers
    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    caa28cb View commit details
    Browse the repository at this point in the history

  8. fix warnings in documentation

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    0254fca View commit details
    Browse the repository at this point in the history

  9. fix formatting issues

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2b6fe24 View commit details
    Browse the repository at this point in the history

  10. Per #1514, add new basic use case to automated test suite

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    d7a52f2 View commit details
    Browse the repository at this point in the history

  11. add step to comment out version number in wrapped MET config file

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    7edf30e View commit details
    Browse the repository at this point in the history

  12. turn off use case to prepare for PR

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    39881e8 View commit details
    Browse the repository at this point in the history

  13. added a pytest fixture to handle comparison of use case commands and … 

    …environment variable values to remove a lot of redundant logic in each wrapper test. Added fake madis data
    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    f6dae72 View commit details
    Browse the repository at this point in the history

  14. removed commented code

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    5d86755 View commit details
    Browse the repository at this point in the history

  15. properly substitute template tags in all command line arguments

    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    2c81513 View commit details
    Browse the repository at this point in the history

  16. properly handle unset rec_beg and rec_end to prevent missing value fr… 

    …om being added to command lien arg
    @georgemccabe
    georgemccabe committed May 16, 2024
    Configuration menu
    Copy the full SHA
    cf1c857 View commit details
    Browse the repository at this point in the history