Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature 267 modulefiles #268

Merged
merged 1 commit into from
Jan 19, 2023
Merged

feature 267 modulefiles #268

merged 1 commit into from
Jan 19, 2023

Conversation

jprestop
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    Used these files to set up the environment on various machines

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None needed. Review files changed if desired.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [N/A]

  • Do these changes include sufficient testing updates? [N/A]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [20230202].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METcalcpy 2.1.0 milestone Jan 19, 2023
@jprestop jprestop linked an issue Jan 19, 2023 that may be closed by this pull request
21 tasks
Copy link
Contributor

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested on mohawk, also looks good.

@hankenstein2 hankenstein2 merged commit 299e5f5 into develop Jan 19, 2023
@hankenstein2 hankenstein2 deleted the feature_267_modulefiles branch January 19, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Update modulefiles in the repository
2 participants