Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2279 point_weight_flag #2993

Merged
merged 56 commits into from
Oct 16, 2024

Commits on Aug 28, 2024

  1. Per #2887, update NumArray::vals() to return a reference to the vecto…

    …r rather a pointer to doubles.
    JohnHalleyGotway committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    09f802e View commit details
    Browse the repository at this point in the history
  2. Per #2887, switch over the whole ContingencyTable class heirarchy fro…

    …m storing integer counts to storing double-precision weights.
    JohnHalleyGotway committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    38a5d4e View commit details
    Browse the repository at this point in the history
  3. Add ContingencyTable::is_integer() member function to check whether t…

    …he table contains all integers
    JohnHalleyGotway committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5e1d81d View commit details
    Browse the repository at this point in the history
  4. Per #2887, update parse_stat_line.cc to get it to compile after chang…

    …ing PCT to store thresholds in a std::vector.
    JohnHalleyGotway committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    32f3601 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5834afd View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    f2a1fd0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c629e6 View commit details
    Browse the repository at this point in the history
  3. Per #2887, update logic of define_prob_bins() to add a final >=1.0 th…

    …reshold if needed. While ==0.1 works fine, I found that ==0.05 did not because the last >=1.0 threshold was missing likely do to floating point precision issues. This change should fix that problem.
    JohnHalleyGotway committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b98276a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dacd1d2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a5403e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Per #2887, replaced all ==0 integer equality checks with calls to is_…

    …eq() instead and fix a couple of equations to snuff out diffs in some CTS statistics.
    JohnHalleyGotway committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    2a68914 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    1b8cd06 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Per #2887, address some of the 34 SonarQube code smells flagged for t…

    …his PR. Note that the compute_ci.h/.cc changes are necessary and good since we should be computing CI's using doubles instead of integer counts.
    JohnHalleyGotway committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    7bce8b8 View commit details
    Browse the repository at this point in the history
  2. Per #2887, update run_sonarqube.sh to specify the target CXX standard…

    … as 11. The hope is that that will limit the findings to only those features available in the C++11 standard.
    JohnHalleyGotway committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f0395b0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8e1ecef View commit details
    Browse the repository at this point in the history
  4. Per #2887, updating build_met_sonarqube.sh to specify --std=c++11 sin…

    …ce c++17 is used by default
    JohnHalleyGotway committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1144765 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    29673cf View commit details
    Browse the repository at this point in the history
  2. Per #2887, swap in a much simpler implementation of the ORSS statisti…

    …c to match the equation listed in the MET User's Guide.
    JohnHalleyGotway committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    1548c75 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    ec99867 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    210eab2 View commit details
    Browse the repository at this point in the history
  3. Per #2887, update grid_stat and library code to actually apply the gr…

    …id_weight_flag settings to the computation of contingency table counts and statistics.
    JohnHalleyGotway committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    33ddd51 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    97cfbfa View commit details
    Browse the repository at this point in the history
  2. Per #2887, add Npairs member to the ContingencyTable class, eliminate…

    … the n() accessor function, and carefully replace references to n() with n_pairs() for the integer number of matched pairs or total() with the double-precision sum of the weights.
    JohnHalleyGotway committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    17dc1b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    ace7c1b View commit details
    Browse the repository at this point in the history
  2. Per #2883, need to call set_n_pairs() in a few spots to set ECLV TOTA…

    …L column correctly ci-run-unit
    JohnHalleyGotway committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    55dbd06 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e44a100 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8e3e6c7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1772df View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Per #2887, reconfigure existing Ensemble-Stat unit test to request pr…

    …obabilistic output to see that it's impacted by the grid_weight_flag setting.
    JohnHalleyGotway committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    1bd61df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88a8c22 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7b9ab8c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2ec2e22 View commit details
    Browse the repository at this point in the history
  5. Per #2887, revise the existing unit_grid_weight.xml unit tests for Gr…

    …id-Stat to write CTC/CTS/MCTC/MCTS output and for the DESC column to be populated to indicate the type of grid weighting that was applied.
    JohnHalleyGotway committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    940c9e2 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    9e4f00f View commit details
    Browse the repository at this point in the history
  2. Per #2279, add the MaskSID struct to store information about station …

    …id names and corresponding weights.
    JohnHalleyGotway committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4bbe2ae View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d3069d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Per #2279, adding point_weight_flag option to all Point-Stat and Ense…

    …mble-Stat config file and tweaking whitespace.
    JohnHalleyGotway committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f5f4d99 View commit details
    Browse the repository at this point in the history
  2. Per #2279, add point_weight_flag to the Point-Stat and Ensemble-Stat …

    …config class. Also remove sue unneeded wgt_dp argument for the add_point_obs() functions. Plan to add logic to set the point weights only AFTER all the observations have been collected for each verification task.
    JohnHalleyGotway committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d520fef View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b2ed2a6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0edcd65 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d5a26b5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9806e0a View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Per #2279, fix a couple bugs parsing the SID weights and add a new un…

    …it_point_weight.xml unit test to run Point-Stat on scalar and probability inputs weighting the stations by their elevation. Still need to add Ensemble-Stat calls.
    JohnHalleyGotway committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    eabaaaf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5723b18 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3beab1f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    764164b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    25ca869 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a0c1dc4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b086ae0 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Configuration menu
    Copy the full SHA
    458c6df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    13fe94a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    02302be View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    40e805b View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Per #2279, move MaskSID from vx_config over into dedicated vx_util/ma…

    …sk_sid.h and .cc to be consistent with mask_poly.h. I note that the members of the MaskSID struct were not being initialized properly. So making it a complete class was the right solution.
    JohnHalleyGotway committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    39b60f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cf13262 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9ecea77 View commit details
    Browse the repository at this point in the history