Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2638 Exclude the height varable as a vertical variable if height has no dimension #2641

Closed

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented Aug 10, 2023

Expected Differences

The variable with the standard name "height" and "air_pressure" is selected as the vertical level variable for NCCF. The sample NetCDF from the user has height variable but not use as the vertical level. Other variable will be selectas as the vertical level variable if the dimension is not 1.

Added a log message with verbose level 5 for the selected coordinate variables.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:
/d1/personal/hsoh/git/pull_request/MET_bugfix_2638_nccf_coordinate_dimension_main_v11.1/bin/plot_data_plane /d1/personal/hsoh/data/MET-2638/percentile_extract_20230729T1200Z-B20230725T0030Z-visibility_at_screen_level.nc plot.ps 'name="visibility_in_air"; level="(1,*,*)";' -v 5

Added log message

DEBUG 5: NcCfFile::open() -> coordinate variables: x=projection_x_coordinate, y=projection_y_coordinate, z=percentile, t=time

And tested following three:

'name="visibility_in_air"; level="(@10,*,*)";'
'name="visibility_in_air"; level="(6,*,*)";'
'name="visibility_in_air"; level="(@50,*,*)";'
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • [x ] Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET 11.1.1 (bugfix) milestone Aug 10, 2023
@hsoh-u hsoh-u requested a review from jprestop August 10, 2023 16:00
@hsoh-u hsoh-u linked an issue Aug 10, 2023 that may be closed by this pull request
20 tasks
@hsoh-u
Copy link
Collaborator Author

hsoh-u commented Aug 10, 2023

I will close this and open new one later.
The fix does not work if the height variable is a 1 dimensional variable.

        float percentile(percentile) ;
                percentile:units = "%" ;
                percentile:long_name = "percentile" ;
        float height (height);
                height:units = "m" ;
                height:standard_name = "height" ;
                height:positive = "up" ;

@hsoh-u hsoh-u closed this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugfix: Refine support for coordinate dimensions in CF-compliant NetCDF files
1 participant