Add support for Application Credential authentication #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milliams
force-pushed
the
app_cred
branch
2 times, most recently
from
4f37ab5 to
450f4a2
Compare
|
Thanks, great addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for Application Credential authentication.
It supports passing the application credential by ID (
application_credential_id/OS_APPLICATION_CREDENTIAL_ID-- the default OpenStack RC and clouds.yaml format), or specifying the credential by name (application_credential_name/OS_APPLICATION_CREDENTIAL_NAME) if the user ID (user_id/OS_USER_ID) is also set.It doesn't currently support setting the application credential by name and also relying on the
username(as that requires setting domains etc.) but that can always be added in later.I have tested this against a live OpenStack Yoga cluster.