Test Unix x86 with asan/ubsan in CI #49
Conversation
| ifeq (debug, $(BUILD)) | ||
| CFLAGS += -O0 -g -DIR_DEBUG=1 | ||
| override CFLAGS += -O0 -g -DIR_DEBUG=1 | ||
| endif |
There was a problem hiding this comment.
I've never known about the "override" before.
I think, it may be better to use a different BUILD type. e.g. "asan" in addition to "release" and "debug".
There was a problem hiding this comment.
https://www.gnu.org/software/make/manual/html_node/Override-Directive.html
If a variable has been set with a command argument (see Overriding Variables), then ordinary assignments in the makefile are ignored. If you want to set the variable in the makefile even though it was set with a command argument, you can use an override directive, which is a line that looks like this:
override variable = value
I think override is a good flag either way, because otherwise users can still set CFLAGS via make CFLAGS=... but local CFLAGS in the Makefile are completely ignored. This can lead to unexpected behavior. I.e. in this case it will cancel the -Wall -Wextra -Wno-unused-parameter, and -O2 -g with the release build, etc. This is not immediately obvious when the removal of the flags doesn't break the build.
No description provided.