Lower case command arguments user and repo #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #84: Ensure
import
andexport
find the same issue directory.I have added lower casing to import/export functions that parse command line arguments. I think I have caught all of them. Four considerations had come to mind:
create_issue
function is used internally in afor
loop in two other functions. So this adds redundant lower casing in these loops. This is unlikely to be a bottleneck though.test.sh
. I can have a go at it, but it will take me a bit of time to understand the test script.$provider
. All definitions of the variable from user input are preceded by an explicit comparison togithub
andgitlab
, making the lower casing entirely redundant. Moving the comparison to after the lower casing is possible to allow, for example,git issue import GitLab <...>
. Please let me know if that is desirable.