This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
Added support for MariaDB #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowdynl
commented
Oct 9, 2020
rowdynl
commented
- Added the option to configure a port for the connection
- Added a influxdb.yaml example
- Edited the README
- Changed the order of requirements (wheel is needed in the fors command too)
- Added information about the influxdb example
- Updated the tested versions example
- Added the option to configure a port for the connection - Added a influxdb.yaml example - Edited the README - Changed the order of requirements (wheel is needed in the fors command too) - Added information about the influxdb example - Updated the tested versions example
dseifert
reviewed
Dec 28, 2020
| parser.add_argument('--database', '-d', | ||
| dest='database', action='store', required=True, | ||
| help='MySQL/MariaDB database') | ||
| dest='database', action='store', required=false, type=int, default=3306, |
There was a problem hiding this comment.
You mixed up port and database here: required, int, 3306 and help text changes belong to the new lines 76/77 (for port)
|
Also, could you rename the PR / commit, please? Nothing in it is specific to MariaDB (both MariaDB and MySQL use the same port, and your other fixes are independent of MariaDB as well). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.