Severe performance improvement in onlyheat calculations of strainMap #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications in pdeHeatEquation() to allow for using every subsystem temperature in each subsystem definition of thermCond. The analytical function can now use T(1),...,T(N) in each of the subsystems. This is in analogy to the usage in the property subsytemCoupling where the diference T(2)-T(1) has to be evaluated.
remove parfor from energyMap() in heat.m
Modification of heat.m, thermCond
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to calcEnergyMap(), it is much more efficient not to vectorize the calculation of the sticks in a onlyheat calculation (no coherent strain response, only adiabatic strain response to stress). The usage of @feval seems to slow down the calculation severely. A test calculation is 7 times faster when using an explicit for-loop for traversing the individual unit cells.
Sorry for the other changes. These are personal changes that do not need to find its way into the upstream.