Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simultaneous write/read access to h5 files #58

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Simultaneous write/read access to h5 files #58

merged 5 commits into from
Dec 27, 2023

Conversation

dschick
Copy link
Owner

@dschick dschick commented Dec 27, 2023

When using h5 files in data acq, it is desired to read the scan file during the scan simultaneously.
For h5 files this feature is introduced by the swmr mode. However, this does not seem to be easy, following this Sardana issue: https://gitlab.com/sardana-org/sardana/-/issues/1124

A very simple solution also done by PyMCA is to disable file locking at all using an environmental variable:
h5py/h5py#712 (comment)

This PR introduces this feature when reading Sardana NeXus and PAL FEL h5 files

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9241a45) 52.25% compared to head (e3c8d03) 52.24%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #58      +/-   ##
===========================================
- Coverage    52.25%   52.24%   -0.01%     
===========================================
  Files           10       10              
  Lines         1064     1068       +4     
===========================================
+ Hits           556      558       +2     
- Misses         508      510       +2     
Files Coverage Δ
pyEvalData/io/palxfel.py 80.00% <100.00%> (+0.68%) ⬆️
pyEvalData/io/sardana_nexus.py 20.37% <20.00%> (-0.79%) ⬇️

@dschick dschick merged commit 80bffe1 into develop Dec 27, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants