Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure-evaluation #42

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Restructure-evaluation #42

wants to merge 27 commits into from

Conversation

dschick
Copy link
Owner

@dschick dschick commented Dec 4, 2021

refractore and restructure the Evaluation class to disentangle evaluation from plotting and use atomic functons for single scans as basis for loops in scan_sequences

@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2021

Codecov Report

Attention: 251 lines in your changes are missing coverage. Please review.

Comparison is base (9241a45) 52.25% compared to head (0fac614) 55.08%.
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
+ Coverage    52.25%   55.08%   +2.83%     
===========================================
  Files           10       10              
  Lines         1064     1042      -22     
===========================================
+ Hits           556      574      +18     
+ Misses         508      468      -40     
Files Coverage Δ
pyEvalData/io/scan.py 61.17% <100.00%> (+5.77%) ⬆️
pyEvalData/io/source.py 69.96% <ø> (ø)
pyEvalData/helpers.py 85.88% <97.56%> (+10.32%) ⬆️
pyEvalData/evaluation.py 33.64% <19.61%> (-1.59%) ⬇️

... and 2 files with indirect coverage changes

Copy link
Owner Author

@dschick dschick Dec 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • unify doc string in whole project
  • add plot separate to jupyter notebook
    • make legends work for plot_separate and show_single
    • reintroduce fig_size, x/y-labels????
    • residuals plot for fit sequences
  • add tests for all helpers
  • add example for filters in jupyter notebook
  • work on composite data sources
  • test and rethink new syntax
    • try to keep old syntax intact at least for main methods plot_scans(), plot_scan_sequence(), fit_scans(), fit_scan_sequence()
  • when thinking about filters and new data from fits and transformatios - how and when should they be calculated and introduced and potentially also saved in the NeXus file???
  • make sequence_type back compatible with label_format for plot_ and fit_scan_sequence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants