-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure-evaluation #42
Open
dschick
wants to merge
27
commits into
develop
Choose a base branch
from
restructure-evaluation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #42 +/- ##
===========================================
+ Coverage 52.25% 55.08% +2.83%
===========================================
Files 10 10
Lines 1064 1042 -22
===========================================
+ Hits 556 574 +18
+ Misses 508 468 -40
|
dschick
commented
Dec 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- unify doc string in whole project
- add plot separate to jupyter notebook
- make legends work for plot_separate and show_single
- reintroduce fig_size, x/y-labels????
- residuals plot for fit sequences
- add tests for all helpers
- add example for filters in jupyter notebook
- work on composite data sources
- test and rethink new syntax
- try to keep old syntax intact at least for main methods plot_scans(), plot_scan_sequence(), fit_scans(), fit_scan_sequence()
- when thinking about filters and new data from fits and transformatios - how and when should they be calculated and introduced and potentially also saved in the NeXus file???
- make
sequence_type
back compatible withlabel_format
for plot_ and fit_scan_sequence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refractore and restructure the Evaluation class to disentangle evaluation from plotting and use atomic functons for single scans as basis for loops in scan_sequences