Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-generic S matrix in LDL factorization #76

Merged
merged 3 commits into from
Dec 26, 2020

Conversation

matbesancon
Copy link
Contributor

Still needs tests, addresses in part the issue observed in #64

@codecov-io
Copy link

codecov-io commented Dec 26, 2020

Codecov Report

Merging #76 (dd9913e) into master (039132b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   89.90%   89.89%   -0.01%     
==========================================
  Files          36       35       -1     
  Lines        2526     2524       -2     
==========================================
- Hits         2271     2269       -2     
  Misses        255      255              
Impacted Files Coverage Δ
src/KKT/ldlfact.jl 94.11% <ø> (ø)
src/KKT/KKT.jl 77.77% <0.00%> (-2.23%) ⬇️
src/Tulip.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039132b...e3f82e0. Read the comment docs.

@matbesancon
Copy link
Contributor Author

I'm checking whether it passes to also add Float32 to the Tv types in the tests. This may be overkill because repeating all tests a third time.

@matbesancon
Copy link
Contributor Author

The Float32 addition adds a lot of tests, up to you to see whether you want to keep them. I believe they are interesting because they prevent bugs for types that would get absorbed by promotion with Float64 (not the case for BigFloat)

@mtanneau
Copy link
Member

Thanks!

I don't mind running the tests with more types. It's the MOI tests that take most time; currently they only run in Float64.

@mtanneau mtanneau merged commit 5066f8b into ds4dm:master Dec 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants