-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Interactive table on gems page #393
Draft
cllns
wants to merge
16
commits into
dry-rb:main
Choose a base branch
from
cllns:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itemized list of things that need to be fixed (I will keep this updated):
|
<table> sources don't work as well with gridjs
Stylize gem name, Re-do categories Sort by default
Fix URL data source to relative path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314.
I'll have to clean this up a bit, especially since I had to tweak the build and deploy scripts to get a demo page up.
Anyway, it took me way too long but I got a demo page up: http://dry.cllns.com/gems/
Let me know what you think!
The table gem I used (gridjs), is quite nice and simple but it doesn't have great support for converting from a
<table>
like we're doing here. I can't format the cells or headers at all (sorting on 'name' is broken and I can't disable it), see grid-js/gridjs#908 . So, if we want to go forward with this, we can generate a .json file instead, and pull that in. Then we'll be able to customize it how we want. (And, later, we could switch the endpoint to a... gasp, real server, if we need.)For "popularity", I used the following system based on the number of downloads each gem has (though I bumped
dry-system
up to ⭐️⭐️ since it's close and about to ship 1.0)⭐️ 0-1MM
⭐️⭐️ 1-10MM
⭐️⭐️⭐️ 10-20MM
⭐️⭐️⭐️⭐️ 20-40MM
⭐️⭐️⭐️⭐️⭐️ 40+MM
The "high-level" option is because @solnic told me there had been talk about grouping them that way before. I don't think what I have is perfect (dry-struct and dry-initializer are low-level but ready for use in apps).
And, there's some logic that's barely surfaced (see Options and Flow Control), based on how I grouped the gems. I'd like to also render a series of
<ul>
s, showing what is built on top of what (maybe inside some cards?) but that can come later.