Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix STARTTLS cap withouth validating if it's mandatory. #2538

Closed
wants to merge 1 commit into from

Conversation

jbiosca78
Copy link

Describe your changes

testssl doesn't check if STARTTLS is mandatory and issues a message to warn users.
But instead of raising a warning message, it caps grade to T, which sets the score to 0. This is incorrect and unfair to users with security concerns.

What is your pull request about?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs and the indentation is five spaces
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

@jbiosca78 jbiosca78 changed the title Fix STARTSSL cap withouth validating if it's mandatory. Fix STARTTLS cap withouth validating if it's mandatory. Aug 7, 2024
@drwetter
Copy link
Owner

But instead of raising a warning message, it caps grade to T, which sets the score to 0. This is incorrect and unfair to users with security concerns.

Au contraire. This is fair to users as STARTTLS involves an upgrade from clear text to TLS which can be intercepted by a man in the middle. A server or a client has no or minimal means to detect this. There are a few tickets about this.

Another thing is the rating. We basically use the one from SSLlabs (with permission). STARTTLS wasn't in scope of that, it's our own addition.

I'll let this hang for a while to reconsider the rating and discussion.

@drwetter
Copy link
Owner

drwetter commented Sep 7, 2024

I'll close this in favor of #2564. Please see comment in the code.

@drwetter drwetter closed this Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants