Strict parser for HSTS #2386
Merged
Strict parser for HSTS #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As suggested in #2381 this parses strictly the value for mag-age in the HSTS header line. While it is implemented only in run_hsts() it could be extracted to a separate functioni in the future and used elsewhere too. The improvement is more strict and catches e.g. '==' signs and issues a warning. See https://www.rfc-editor.org/rfc/rfc6797#section-6.1.1 . Also it is picky regarding quotes now which are only allowed enclosing the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #2381 this parses strictly the value for max-age in the HSTS header line. While it is implemented only in run_hsts() it could be extracted to a separate function in the future and used elsewhere too.
The improvement is strict and catches also e.g. '==' signs and issues a warning. See https://www.rfc-editor.org/rfc/rfc6797#section-6.1.1 .
Also it is picky regarding quotes now which are only allowed enclosing the value.