Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update optionaldependency vue to v3 #504

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 17, 2022

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
vue (source) ^2.7.16 -> ^3.4.38 age adoption passing confidence
vue (source) 2.7.16 -> 3.4.38 age adoption passing confidence

Release Notes

vuejs/core (vue)

v3.4.38

Compare Source

For stable releases, please refer to CHANGELOG.md for details.
For pre-releases, please refer to CHANGELOG.md of the minor branch.

v3.4.37

Compare Source

Bug Fixes

v3.4.36

Compare Source

v3.4.35

Compare Source

Bug Fixes
  • teleport/ssr: fix Teleport hydration regression due to targetStart anchor addition (7b18cdb)
  • teleport/ssr: ensure targetAnchor and targetStart not null during hydration (#​11456) (12667da), closes #​11400
  • types/ref: allow getter and setter types to be unrelated (#​11442) (e0b2975)
Performance Improvements

v3.4.34

Compare Source

Bug Fixes

v3.4.33

Compare Source

Bug Fixes

v3.4.32

Compare Source

Bug Fixes
Performance Improvements
  • server-renderer: avoid unnecessary checks in createBuffer (#​11364) (fc205bf)
  • server-renderer: optimize unrollBuffer by avoiding promises (#​11340) (05779a7)

v3.4.31

Compare Source

Bug Fixes
Reverts
  • Revert "fix(reactivity): avoid infinite loop when render access a side effect computed (#​11135)" (e0df985)
  • Revert "fix(reactivity): fix side effect computed dirty level (#​11183)" (6c303ea), closes #​11183

v3.4.30

Compare Source

Bug Fixes
Performance Improvements

v3.4.29

Compare Source

Bug Fixes
  • build: fix accidental inclusion of runtime-core in server-renderer cjs build (11cc12b), closes #​11137
  • compiler-sfc: fix missing scope for extends error message (4ec387b)
  • compiler-sfc: fix parsing of mts, d.mts, and mtsx files (a476692)
  • compiler-sfc: support @​vue-ignore comment on more type sources (a23e99b)
  • custom-element: support same direct setup function signature in defineCustomElement (7c8b126), closes #​11116
  • reactivity: avoid infinite loop when render access a side effect computed (#​11135) (8296e19), closes #​11121

v3.4.28

Compare Source

Bug Fixes

v3.4.27

Compare Source

Bug Fixes

v3.4.26

Compare Source

Bug Fixes

v3.4.25

Compare Source

Bug Fixes

v3.4.24

Compare Source

Bug Fixes

v3.4.23

Compare Source

Bug Fixes
  • runtime-core: fix regression for $attrs tracking in slots (6930e60), closes #​10710
  • runtime-core: use same internal object mechanism for slots (6df53d8), closes #​10709

v3.4.22

Compare Source

Bug Fixes
Performance Improvements
  • add __NO_SIDE_EFFECTS__ comments (#​9053) (d46df6b)
  • optimize component props/slots internal object checks (6af733d)
  • ssr: avoid calling markRaw on component instance proxy (4bc9f39)
  • ssr: optimize setup context creation for ssr in v8 (ca84316)

v3.4.21

Compare Source

Bug Fixes

v3.4.20

Compare Source

Bug Fixes

v3.4.19

Compare Source

Bug Fixes
Features

Note: this warning is categorized as a feature but released in a patch because it does not affect public APIs.

Performance Improvements

v3.4.18

Compare Source

Bug Fixes

v3.4.17

Compare Source

Reverts

v3.4.16

Compare Source

Bug Fixes
Reverts

v3.4.15

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label May 17, 2022
@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

⚠️ No Changeset found

Latest commit: ca07f32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 5 times, most recently from 139669e to f86d1f0 Compare May 24, 2022 02:28
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from f86d1f0 to 5dbe749 Compare June 6, 2022 14:34
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from 5dbe749 to 9c393d1 Compare July 8, 2022 12:14
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from 9c393d1 to 0c13be4 Compare August 3, 2022 00:02
@renovate renovate bot changed the title chore(deps): update vue monorepo (major) chore(deps): update vue monorepo to v3 (major) Aug 9, 2022
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 2 times, most recently from 99f050d to 157c0c8 Compare August 10, 2022 04:41
@renovate renovate bot changed the title chore(deps): update vue monorepo to v3 (major) chore(deps): update vue monorepo (major) Aug 10, 2022
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 3 times, most recently from 365053c to d089ffb Compare August 12, 2022 01:34
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 8 times, most recently from 03fb953 to 2709ab4 Compare August 29, 2022 01:01
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 4 times, most recently from e00e9d3 to dd7b30e Compare August 30, 2022 03:28
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from f00e57d to c3b4d59 Compare June 14, 2024 10:45
Copy link
Contributor Author

renovate bot commented Jun 14, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: yarn.lock
/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21609
    throw new Error(
          ^

Error: Error when performing the request to https://registry.npmjs.org/yarn/latest; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting
    at fetch (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21609:11)
    at async fetchAsJson (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21623:20)
    ... 4 lines matching cause stack trace ...
    at async Object.runMain (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:23096:5) {
  [cause]: TypeError: globalThis.fetch is not a function
      at fetch (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21603:33)
      at async fetchAsJson (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21623:20)
      at async fetchLatestStableVersion (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21550:20)
      at async fetchLatestStableVersion2 (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:21672:14)
      at async Engine.getDefaultVersion (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22292:23)
      at async Engine.executePackageManagerRequest (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22390:47)
      at async Object.runMain (/opt/containerbase/tools/corepack/0.29.3/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:23096:5)
}

@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from c3b4d59 to bb09ab1 Compare June 14, 2024 16:35
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 2 times, most recently from a9119a4 to 845928c Compare June 28, 2024 04:43
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 2 times, most recently from 1f8800b to a09197f Compare July 19, 2024 11:37
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 2 times, most recently from bccdb1b to 118234d Compare July 31, 2024 09:23
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from 118234d to e84ba93 Compare August 6, 2024 14:38
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (2)
packages/menu/package.json (1)

51-51: Update required for Vue 3 compatibility

The codebase contains instances of Vue 2 specific syntax that need to be updated for compatibility with Vue 3. Specifically, the following occurrences were found:

  • Vue.use(Vuex)
  • Vue.use(VueRouter)
  • Vue.component
  • Vue.mixin

These instances are primarily located in test files and a few source files. Please update these to their Vue 3 equivalents to ensure full compatibility.

  • Files to update:
    • packages/breadcrumb/test/components/DruxtBreadcrumb.test.js
    • packages/views/test/components/DruxtViewsPager.test.js
    • packages/views/test/components/DruxtViewsSorts.test.js
    • packages/views/test/components/DruxtViewsFilter.test.js
    • packages/views/test/components/blocks/DruxtBlockViewsBlock.test.js
    • packages/views/test/components/DruxtView.test.js
    • packages/views/test/stores/views.test.js
    • packages/schema/test/mixins/schema.test.js
    • packages/router/test/stores/router.test.js
    • packages/router/test/mixins/entity.test.js
    • packages/schema/test/stores/schema.test.js
    • packages/router/test/components/DruxtRouter.test.js
    • packages/site/test/components/DruxtSite.test.js
    • packages/site/test/mixins/site.test.js
    • packages/druxt/test/stores/druxt.test.js
    • packages/druxt/test/components/DruxtModule.test.js
    • packages/blocks/test/components/DruxtBlock.test.js
    • packages/blocks/test/components/DruxtBlockRegion.test.js
    • packages/blocks/test/components/blocks/DruxtBlockPageTitleBlock.test.js
    • packages/blocks/test/components/blocks/DruxtBlockBlockContent.test.js
    • packages/druxt/src/index.js
    • packages/entity/test/mixins/componentSuggestion.test.js
    • packages/entity/test/components/fields/DruxtFieldEntityReferenceLabel.test.js
    • packages/entity/test/components/fields/DruxtFieldResponsiveImage.test.js
    • packages/druxt/src/plugins/devtools.js
    • packages/entity/test/components/fields/DruxtFieldEntityReferenceEntityView.test.js
    • packages/entity/test/components/fields/DruxtFieldNumberInteger.test.js
    • packages/blocks/test/mixins/block.test.js
    • packages/entity/test/components/fields/DruxtFieldFileDefault.test.js
    • packages/entity/test/components/fields/DruxtFieldLink.test.js
    • packages/menu/test/stores/menu.test.js
    • packages/entity/test/components/DruxtEntityFormButtons.test.js
    • packages/menu/test/components/DruxtMenuItem.test.js
    • packages/entity/test/components/DruxtEntityForm.test.js
    • packages/entity/test/components/DruxtEntity.test.js
    • packages/entity/test/components/DruxtField.test.js
    • packages/menu/test/components/DruxtMenu.test.js
Analysis chain

Verify compatibility with Vue 3.

The update from Vue 2 to Vue 3 may introduce breaking changes. Ensure that the codebase is compatible with Vue 3, including components, directives, and overall application architecture.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility with Vue 3.

# Test: Search for Vue 2 specific syntax. Expect: No occurrences of Vue 2 specific syntax.
rg --type vue -e 'Vue\.extend' -e 'Vue\.component' -e 'Vue\.directive' -e 'Vue\.filter' -e 'Vue\.mixin' -e 'Vue\.use'

Length of output: 147


Script:

#!/bin/bash
# Description: Verify compatibility with Vue 3 by searching for Vue 2 specific syntax.

# Test: Search for Vue 2 specific syntax in .vue, .js, and .ts files. Expect: No occurrences of Vue 2 specific syntax.
rg -t vue -t js -t ts -e 'Vue\.extend' -e 'Vue\.component' -e 'Vue\.directive' -e 'Vue\.filter' -e 'Vue\.mixin' -e 'Vue\.use'

Length of output: 155


Script:

#!/bin/bash
# Description: Verify compatibility with Vue 3 by searching for Vue 2 specific syntax.

# Test: Search for Vue 2 specific syntax in .vue, .js, and .ts files. Expect: No occurrences of Vue 2 specific syntax.
rg --glob '*.vue' --glob '*.js' --glob '*.ts' -e 'Vue\.extend' -e 'Vue\.component' -e 'Vue\.directive' -e 'Vue\.filter' -e 'Vue\.mixin' -e 'Vue\.use'

Length of output: 4011

packages/site/package.json (1)

57-57: Significant upgrade to Vue 3.

The update from Vue 2 to Vue 3 introduces breaking changes and new features. The following instances of Vue 2 specific syntax were found in the codebase and need to be updated to ensure compatibility with Vue 3:

  • this.$scopedSlots found in:
    • packages/druxt/src/components/DruxtModule.vue
    • packages/router/test/components/DruxtRouter.test.js

Please update these instances to use the new this.$slots syntax in Vue 3.

Analysis chain

Significant upgrade to Vue 3.

The update from Vue 2 to Vue 3 introduces breaking changes and new features. Ensure that the codebase is compatible with Vue 3, and verify that all components, plugins, and dependencies work correctly with the new version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility of the codebase with Vue 3.

# Test: Check for Vue 2 specific syntax or deprecated features.
rg --type vue -e 'Vue\.extend' -e 'this\.\$scopedSlots' -e '\$listeners' -e 'beforeDestroy' -e 'destroyed'

Length of output: 132


Script:

#!/bin/bash
# Description: Verify compatibility of the codebase with Vue 3.

# Find all .vue files and search for Vue 2 specific syntax or deprecated features within them.
find . -name "*.vue" -print0 | xargs -0 rg -e 'Vue\.extend' -e 'this\.\$scopedSlots' -e '\$listeners' -e 'beforeDestroy' -e 'destroyed'

# Additionally, search for Vue 2 specific syntax or deprecated features across all files.
rg -e 'Vue\.extend' -e 'this\.\$scopedSlots' -e '\$listeners' -e 'beforeDestroy' -e 'destroyed'

Length of output: 1040

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0e8d98a and e84ba93.

Files selected for processing (9)
  • package.json (1 hunks)
  • packages/blocks/package.json (1 hunks)
  • packages/breadcrumb/package.json (1 hunks)
  • packages/druxt/package.json (1 hunks)
  • packages/menu/package.json (1 hunks)
  • packages/router/package.json (1 hunks)
  • packages/schema/package.json (1 hunks)
  • packages/site/package.json (1 hunks)
  • packages/views/package.json (1 hunks)
Additional comments not posted (7)
packages/schema/package.json (1)

47-47: Update optional dependency vue to version ^3.4.36.

The vue dependency has been updated from ^2.7.14 to ^3.4.36. This major version upgrade introduces new features and improvements but may also include breaking changes. Ensure that the codebase is compatible with Vue 3.

packages/breadcrumb/package.json (1)

50-50: Update optional dependency vue to version ^3.4.36.

The vue dependency has been updated from ^2.7.14 to ^3.4.36. This major version upgrade introduces new features and improvements but may also include breaking changes. Ensure that the codebase is compatible with Vue 3.

packages/blocks/package.json (1)

52-52: Update optional dependency vue to version ^3.4.36.

The vue dependency has been updated from ^2.7.14 to ^3.4.36. This major version upgrade introduces new features and improvements but may also include breaking changes. Ensure that the codebase is compatible with Vue 3.

packages/router/package.json (1)

55-55: Verify compatibility with Vue 3.

The update from Vue 2 to Vue 3 may introduce breaking changes. Ensure that the codebase is compatible with Vue 3, including components, directives, and overall application architecture.

packages/views/package.json (1)

54-54: Verify compatibility with Vue 3.

The update from Vue 2 to Vue 3 may introduce breaking changes. Ensure that the codebase is compatible with Vue 3, including components, directives, and overall application architecture.

packages/druxt/package.json (1)

64-64: Significant upgrade to Vue 3.

The update from Vue 2 to Vue 3 introduces breaking changes and new features. Ensure that the codebase is compatible with Vue 3, and verify that all components, plugins, and dependencies work correctly with the new version.

package.json (1)

65-65: Significant upgrade to Vue 3.

The update from Vue 2 to Vue 3 introduces breaking changes and new features. Ensure that the codebase is compatible with Vue 3, and verify that all components, plugins, and dependencies work correctly with the new version.

@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from e84ba93 to 89f8789 Compare August 8, 2024 16:34
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (2)
packages/druxt/package.json (1)

64-64: Update deprecated Vue 2 features for Vue 3 compatibility.

The following deprecated Vue 2 features were found in the codebase and need to be updated for compatibility with Vue 3:

  • Vue.set is used extensively in src/stores files such as packages/views/src/stores/views.js and packages/menu/src/stores/menu.js.
  • Vue.use, Vue.component, and Vue.nextTick are used in various test files, including:
    • packages/views/test/components/DruxtViewsFilters.test.js
    • packages/menu/test/components/DruxtMenu.test.js
    • packages/entity/test/components/DruxtEntityForm.test.js

Please review these occurrences and refactor them to ensure compatibility with Vue 3. Consider using Vue 3's composition API or other recommended patterns.

Analysis chain

Verify compatibility with Vue 3.

The upgrade from Vue 2 to Vue 3 is significant and may introduce breaking changes. Ensure that all components and dependencies are compatible with Vue 3.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for Vue 3 compatibility issues in the codebase.

# Test: Search for deprecated Vue 2 features. Expect: No occurrences of deprecated features.
rg --type vue $'Vue.extend|Vue.observable|Vue.set|Vue.delete|Vue.nextTick|Vue.component|Vue.directive|Vue.filter|Vue.mixin|Vue.use|Vue.prototype|Vue.config'

Length of output: 185


Script:

#!/bin/bash
# Description: Check for Vue 3 compatibility issues in the codebase by searching for deprecated Vue 2 features.

# Test: Search for deprecated Vue 2 features in .vue and .js files.
rg --glob '*.vue' --glob '*.js' 'Vue.extend|Vue.observable|Vue.set|Vue.delete|Vue.nextTick|Vue.component|Vue.directive|Vue.filter|Vue.mixin|Vue.use|Vue.prototype|Vue.config'

Length of output: 9219

package.json (1)

65-65: Review and refactor deprecated Vue 2 features for Vue 3 compatibility.

The following files contain deprecated Vue 2 features that need to be reviewed and refactored to ensure compatibility with Vue 3:

  • packages/site/test/mixins/site.test.js
  • packages/site/test/components/DruxtSite.test.js
  • packages/views/src/stores/views.js
  • packages/menu/src/stores/menu.js
  • packages/router/src/stores/router.js
  • packages/druxt/src/stores/druxt.js
  • packages/druxt/src/index.js

Please ensure these features are updated to their Vue 3 equivalents.

Analysis chain

Verify compatibility with Vue 3.

The upgrade from Vue 2 to Vue 3 is significant and may introduce breaking changes. Ensure that all components and dependencies are compatible with Vue 3.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for Vue 3 compatibility issues in the codebase.

# Test: Search for deprecated Vue 2 features. Expect: No occurrences of deprecated features.
rg --type vue $'Vue.extend|Vue.observable|Vue.set|Vue.delete|Vue.nextTick|Vue.component|Vue.directive|Vue.filter|Vue.mixin|Vue.use|Vue.prototype|Vue.config'

Length of output: 185


Script:

#!/bin/bash
# Description: Check for Vue 3 compatibility issues in the codebase.

# Test: Search for deprecated Vue 2 features in JavaScript and Vue files. Expect: No occurrences of deprecated features.
rg --type js --type-add 'vue:*.vue' $'Vue.extend|Vue.observable|Vue.set|Vue.delete|Vue.nextTick|Vue.component|Vue.directive|Vue.filter|Vue.mixin|Vue.use|Vue.prototype|Vue.config'

Length of output: 9223

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e84ba93 and 89f8789.

Files selected for processing (9)
  • package.json (1 hunks)
  • packages/blocks/package.json (1 hunks)
  • packages/breadcrumb/package.json (1 hunks)
  • packages/druxt/package.json (1 hunks)
  • packages/menu/package.json (1 hunks)
  • packages/router/package.json (1 hunks)
  • packages/schema/package.json (1 hunks)
  • packages/site/package.json (1 hunks)
  • packages/views/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • packages/blocks/package.json
  • packages/menu/package.json
  • packages/router/package.json
Additional comments not posted (4)
packages/schema/package.json (1)

47-47: Verify compatibility with Vue 3.

The upgrade from Vue 2 to Vue 3 may introduce breaking changes. Ensure that all components and dependencies are compatible with Vue 3.

packages/breadcrumb/package.json (1)

50-50: Verify compatibility with Vue 3.

The upgrade from Vue 2 to Vue 3 may introduce breaking changes. Ensure that all components and dependencies are compatible with Vue 3.

packages/views/package.json (1)

54-54: Verify compatibility with Vue 3.

The upgrade from Vue 2 to Vue 3 may introduce breaking changes. Ensure that all components and dependencies are compatible with Vue 3.

packages/site/package.json (1)

57-57: Verify compatibility with Vue 3.

The upgrade from Vue 2 to Vue 3 is significant and may introduce breaking changes. Ensure that all components and dependencies are compatible with Vue 3.

@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from 89f8789 to 181d1f7 Compare August 15, 2024 11:36
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (2)
packages/site/package.json (1)

57-57: Update Vue 2 specific features for Vue 3 compatibility

The codebase contains instances of Vue 2 specific features, such as Vue.mixin and Vue.use, which need to be updated to ensure compatibility with Vue 3. Although some parts of the codebase have been updated with Vue 3 features, a comprehensive migration is necessary to avoid potential issues.

  • packages/druxt/src/plugins/devtools.js: Vue.mixin is used.
  • packages/druxt/src/index.js: Vue.use is referenced.

Please ensure that these and any other Vue 2 specific usages are updated according to Vue 3 migration guidelines.

Analysis chain

Verify compatibility with Vue 3.

The update from Vue 2 to Vue 3 is a major version change that may introduce breaking changes. Ensure that the codebase is updated to accommodate these changes, particularly in components, directives, and lifecycle methods.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify codebase compatibility with Vue 3.

# Test: Search for Vue 2 specific features that may need updates for Vue 3 compatibility.
rg --type js -A 5 'Vue\.extend|Vue\.component|Vue\.mixin|Vue\.directive|Vue\.filter|Vue\.use'

Length of output: 18576


Script:

#!/bin/bash
# Search for Vue 2 specific features in the main application code that may need updates for Vue 3 compatibility.
rg --type js -A 5 'Vue\.extend|Vue\.component|Vue\.mixin|Vue\.directive|Vue\.filter|Vue\.use' --glob '!**/test/**'

# Check for Vue 3 specific features or migration notes in the codebase.
rg --type js -A 5 'createApp|defineComponent|ref|reactive|toRefs|setup|onMounted|onUnmounted|watch|computed'

Length of output: 142320

package.json (1)

65-65: Update codebase for Vue 3 compatibility.

The codebase still contains Vue 2 specific patterns and dependencies that need to be updated for full compatibility with Vue 3:

  • Replace vue-template-compiler with @vue/compiler-sfc in package.json.

  • Update instances of Vue.component and other Vue 2 specific APIs found in test files to use Vue 3 compatible patterns.

  • Files to update:

    • package.json: Replace vue-template-compiler.
    • Test files using Vue.component.

Ensure that all components and configurations are compatible with Vue 3's new features and breaking changes.

Analysis chain

Verify compatibility with Vue 3.

The update from Vue 2 to Vue 3 is a major version change and may introduce breaking changes. Ensure that the codebase is compatible with Vue 3, particularly in areas involving the Composition API and other Vue-specific functionalities. Additionally, check if related dependencies, such as vue-template-compiler, need to be updated or replaced with @vue/compiler-sfc for Vue 3 compatibility.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility with Vue 3 and check if related dependencies need updates.

# Test: Search for usage of Vue 2 specific APIs or configurations. Expect: No outdated patterns.
rg --type vue --type js --type ts -A 5 $'Vue.extend|Vue.component|Vue.directive|Vue.filter'

# Check: Verify if `vue-template-compiler` is used and suggest replacing it with `@vue/compiler-sfc`.
rg --type json -A 5 $'"vue-template-compiler"'

Length of output: 298


Script:

#!/bin/bash
# Description: Check for the presence of .vue files and search for Vue 2 specific patterns in JavaScript and TypeScript files.

# Check: List all .vue files to confirm their existence.
fd --extension vue

# Test: Search for usage of Vue 2 specific APIs or configurations in JavaScript and TypeScript files.
rg --type js --type ts -A 5 $'Vue.extend|Vue.component|Vue.directive|Vue.filter'

Length of output: 9221

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 89f8789 and 181d1f7.

Files selected for processing (9)
  • package.json (1 hunks)
  • packages/blocks/package.json (1 hunks)
  • packages/breadcrumb/package.json (1 hunks)
  • packages/druxt/package.json (1 hunks)
  • packages/menu/package.json (1 hunks)
  • packages/router/package.json (1 hunks)
  • packages/schema/package.json (1 hunks)
  • packages/site/package.json (1 hunks)
  • packages/views/package.json (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • packages/menu/package.json
  • packages/router/package.json
Additional comments not posted (5)
packages/schema/package.json (1)

47-47: Verify compatibility with Vue 3.

The update to Vue 3 introduces breaking changes and new features. Ensure that the codebase is compatible with Vue 3 by reviewing components and features that rely on Vue-specific functionality.

Verification successful

No Vue 2 specific syntax found; recommend further manual review for full compatibility with Vue 3.

The search did not find any occurrences of common Vue 2 specific syntax in JavaScript and TypeScript files. However, for complete assurance of compatibility with Vue 3, consider reviewing other aspects such as lifecycle hooks, component registration, and Vuex usage.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility with Vue 3 by searching for Vue 2 specific syntax or features.

# Test: Search for common Vue 2 specific syntax or features. Expect: No occurrences found.
rg --type vue --type js --type ts -e 'Vue\.extend' -e 'this\.\$set' -e 'this\.\$delete' -e 'this\.\$on' -e 'this\.\$off' -e 'this\.\$once'

Length of output: 168


Script:

#!/bin/bash
# Description: Verify compatibility with Vue 3 by searching for Vue 2 specific syntax or features.

# Test: Search for common Vue 2 specific syntax or features in JavaScript and TypeScript files. Expect: No occurrences found.
rg --type js --type ts -e 'Vue\.extend' -e 'this\.\$set' -e 'this\.\$delete' -e 'this\.\$on' -e 'this\.\$off' -e 'this\.\$once'

Length of output: 129

packages/breadcrumb/package.json (1)

50-50: Verify compatibility with Vue 3.

The update to Vue 3 introduces breaking changes and new features. Ensure that the codebase is compatible with Vue 3 by reviewing components and features that rely on Vue-specific functionality.

packages/blocks/package.json (1)

52-52: Verify compatibility with Vue 3.

The update to Vue 3 introduces breaking changes and new features. Ensure that the codebase is compatible with Vue 3 by reviewing components and features that rely on Vue-specific functionality.

packages/views/package.json (1)

54-54: Verify compatibility with Vue 3.

The update from Vue 2 to Vue 3 is a major version change that may introduce breaking changes. Ensure that the codebase is updated to accommodate these changes, particularly in components, directives, and lifecycle methods.

packages/druxt/package.json (1)

64-64: Verify compatibility with Vue 3.

The update from Vue 2 to Vue 3 is a major version change that may introduce breaking changes. Ensure that the codebase is updated to accommodate these changes, particularly in components, directives, and lifecycle methods.

@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch 9 times, most recently from 268b242 to 635e6e2 Compare August 29, 2024 23:16
@renovate renovate bot force-pushed the renovate/major-vue-monorepo branch from 635e6e2 to ca07f32 Compare August 29, 2024 23:48
@Decipher
Copy link
Member

Not a bot task. See #337

@Decipher Decipher closed this Aug 29, 2024
Copy link
Contributor Author

renovate bot commented Aug 29, 2024

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 3.x releases. But if you manually upgrade to 3.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/major-vue-monorepo branch August 29, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant