Drush commands for workspaces - #5933 #5934
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcomio
commented
Apr 8, 2024
| return; | ||
| } | ||
|
|
||
| $workspace->publish(); |
There was a problem hiding this comment.
this fails with wse enabled, because \Drupal\wse_preview\Negotiator\CookieWorkspaceNegotiator::unsetActiveWorkspace tries to get the user session
amateescu
reviewed
Apr 16, 2024
| #[CLI\Command(name: 'workspaces:publish')] | ||
| #[CLI\Argument(name: 'id', description: 'The workspace to publish.')] | ||
| #[CLI\Usage(name: 'workspaces:publish stage', description: 'Publish the stage workspace')] | ||
| public function commandName($id) { |
There was a problem hiding this comment.
We need to ensure that the module is enabled: #[CLI\ValidateModulesEnabled(modules: ['workspaces'])]
weitzman
reviewed
Sep 3, 2024
|
This needs Drush test coverage. I think an integration test will fit well. As setup the command would create a workspace, make it active, create a node in the workspace, run the drush command, and ensure the node is now published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to fix #5933