DB API - Adding support for dynamic parameters #258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Druids SQL Dynamic Parameters.
dynamic_parameters=True
can be set on thedb.api.connect
method. It's set toFalse
by defaultcontext.parameters
JSON payload, regardless of the Dict parameters insertion order ensuring support for Python Verisons< 3.7
SQLAlchemy breaking change fix
Exception was being raised when using the DB API independantly of SQLAlchemy, it was attempting to import
CompileError
but this is an optional dependency as defined inextras_require
. This was introduced in the enhancement #243 - the fix facilitates backwards compatibility but preserves the new enhancement.