PHP-Xero updates #19
Open
PHP-Xero updates #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and begins trying to parse it, resulting in a lot of errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks for writing this class, it's been so helpful. I did encounter a few bugs and issues since using it, which I've fixed in my repo. These add proper support for PDF, get rid of a lot of php errors stemming from the class expecting xml where xml wasn't returned, fixing issues with authentication and various other gotchas I encountered.
It'd be awesome if some of these changes could flow upstream to your repo (since that's where everyone goes first when they start using the xero api).
Thanks!