Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to support ng 13 #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dylannnn
Copy link

No description provided.

@dylannnn
Copy link
Author

@drozhzhin-n-e Would you please review this change and publish the latest version of this library?

@dylannnn
Copy link
Author

@cah-alexsukhodolsky Do you have permission to merge this PR and publish it to npm?

@beneccli
Copy link

For people in need, since this project doesn't seem maintained anymore, I published a fixed version of this repo based mostly on @dylannnn work with a few fixes.
You can use the following instead in your package:

"ng2-tooltip-directive-ng13fix": "^2.10.0",

Note: it's not maintained, it's just a quick and dirty fix for using angular 13.

@Stan92
Copy link

Stan92 commented Apr 7, 2022

@beneccli thanks for sharing.. but it seems there's an issue using template (the tooltip content returns [object Object])

<ng-template #TooltipContent>
   <div>Content</div>
</ng-template>
<div  [tooltip]="TooltipContent" content-type="template" theme="light">Test</div>

@beneccli
Copy link

beneccli commented Apr 7, 2022

@Stan92 Just updated my fork to fix that, published on npm under version 2.10.1:

"ng2-tooltip-directive-ng13fix": "^2.10.1",

@IslombekHasan
Copy link

IslombekHasan commented May 1, 2022

@beneccli bruv, thank you so much! but, could you please check that error above again? it still shows [Object Object] if used with template. you're the only one 🙏

@IslombekHasan
Copy link

@Stan92 did you get it working somehow?

@Stan92
Copy link

Stan92 commented May 4, 2022

@IslombekMe ,

I've changed the template support

<ng-template #TooltipContent>
   <div>Content</div>
</ng-template>
<div  [tooltip]="TooltipContent" content-type="template" theme="light">Test</div>

into "inline" mode

<div tooltip="<div>Content</div>" [options]="tooltipOptions" theme="light">Test</div>

   tooltipOptions = {
        'placement': 'top',
        'content-type': 'html',
        'show-delay': 500
    }

@IslombekHasan
Copy link

@Stan92 thanks for the reply! :) I'll go ahead and try that out.

@IslombekHasan
Copy link

@Stan92 i got it working with template too!

All I needed to do was to use 'camelCase' property names instead of 'kebab-case' and voila!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants