Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtype preserving objective c wrapper to two more locations #321

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

julianlocke
Copy link
Contributor

There were a few more places that the api type subtype information was being thrown away while wrapping for objc compatibility. This PR moves the functions used to create and trigger calling the subtype preserving wrapper to swift_helpers, then instead of writing wrapping code where it is needed we move it to a static method that we can call in the three places we need it.

Continues to fix dropbox/SwiftyDropbox#399

Output code visible in: dropbox/SwiftyDropbox#402

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 103 lines in your changes are missing coverage. Please review.

Comparison is base (94fa542) 50.30% compared to head (b7a315d) 49.94%.
Report is 13 commits behind head on swifty-dropbox-beta.

Files Patch % Lines
stone/backends/swift_helpers.py 0.00% 34 Missing ⚠️
stone/backends/swift_client.py 0.00% 26 Missing ⚠️
stone/backends/swift_types.py 0.00% 25 Missing ⚠️
stone/cli.py 0.00% 16 Missing ⚠️
stone/backends/swift.py 0.00% 1 Missing ⚠️
stone/frontend/ir_generator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           swifty-dropbox-beta     #321      +/-   ##
=======================================================
- Coverage                50.30%   49.94%   -0.37%     
=======================================================
  Files                       37       37              
  Lines                     8740     8803      +63     
  Branches                  1881     1888       +7     
=======================================================
  Hits                      4397     4397              
- Misses                    4026     4089      +63     
  Partials                   317      317              
Flag Coverage Δ
unit 49.94% <0.96%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julianlocke julianlocke merged commit e34ddc0 into swifty-dropbox-beta Feb 9, 2024
11 of 12 checks passed
@julianlocke julianlocke deleted the more-subtype-objc-wrapping branch February 9, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants