Fix custom transport client auth state #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransport clients on re-auth
jaquish
approved these changes
Mar 13, 2024
| requestsToReconnect: requestsToReconnect | ||
| ) | ||
| if let token = token(for: oauthSetupIntent.userKind, using: oAuthManager) { | ||
| setUpAuthorizedClient( |
There was a problem hiding this comment.
Should there be an error logged for no token?
There was a problem hiding this comment.
It's actually a valid state, the model here is that users should call the setup* function on every launch. Auth can be performed afterwards if needed.
| @@ -136,33 +141,34 @@ public class DropboxClientsManager { | |||
| } | |||
| } | |||
|
|
|||
| public static func reauthorizeClient(_ tokenUid: String, sessionConfiguration: NetworkSessionConfiguration? = nil) { | |||
| public static func reauthorizeClient(_ tokenUid: String, sessionConfiguration: NetworkSessionConfiguration? = nil, transportClient: DropboxTransportClient? = nil) { | |||
There was a problem hiding this comment.
nit: put args in the same order as setupAuthorizedClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in this GitHub issue the singleton that 3p developers use to set up their clients behaves incorrectly when the setup method is called with a non-nil transport client when an access token is not persisted.
In sdk versions < 10 we always checked to see if there was an access token before initializing an authorized client, and that logic was lost in a refactor. This PR restored that logic.
Additionally, it adds parity between the differently timed setup methods, adding the ability to pass in a transport client to the reauth*Client methods, and adding a handleRedirectURL flavor that matches the flavors of the setup methods that just take session and container identifiers.