Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vesc namespace #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add vesc namespace #39

wants to merge 1 commit into from

Conversation

jschall
Copy link

@jschall jschall commented Aug 9, 2023

No description provided.

tridge
tridge requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide a bit of explanation for this? Is this an existing message that VESC implements, or is this one you are adding?

tridge
tridge requested changes Aug 31, 2023
View reviewed changes
vesc/20601.RTData.uavcan
float16 volt_d
float16 volt_q

# Temperatures
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comments on units

vesc/20601.RTData.uavcan
float16 temp_motor_1
float16 temp_motor_2

# Currents
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

units (amps?)

vesc/20601.RTData.uavcan
float16 curr_d
float16 curr_q

# IMU
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

units (radians? degrees?)

vesc/20601.RTData.uavcan
float16 roll
float16 pitch
float16 yaw
float16 acc_x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

units - m/s/s?

vesc/20601.RTData.uavcan
float16 gyro_y
float16 gyro_z

# Other
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

units for these too

vesc/20601.RTData.uavcan
#

# Voltages
float16 volt_in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

units

@jschall
Copy link
Author

jschall commented Dec 8, 2023

@tridge this is an existing message that VESC implements. I have nothing to do with it, I just want VESC to work with the dronecan tooling.

@bugobliterator
Copy link
Collaborator

@tridge this is an existing message that VESC implements. I have nothing to do with it, I just want VESC to work with the dronecan tooling.

Can you add a link to the message definition for reference? I believe this is the reference for this message spec https://github.com/vedderb/bldc/blob/master/documentation/comm_can.md ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tridge tridge tridge requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschall @bugobliterator @tridge