Add option to specify Amazon EC2 instance metadata accessiblity #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhamalai
force-pushed
the
ec2_imds_access
branch
from
06ccfe2
to
ad88710
Compare
bradrydzewski
requested changes
Jan 7, 2022
hhamalai
force-pushed
the
ec2_imds_access
branch
2 times, most recently
from
2724336
to
02190a5
Compare
hhamalai
force-pushed
the
ec2_imds_access
branch
from
02190a5
to
a9dc23c
Compare
|
Thanks for the comments @bradrydzewski, I carried out the changes you suggested and rebased on master. |
|
@bradrydzewski , any ideas to improve this PR, or is it off the scope for the project, and should I close it and try to tackle this issue with another approach? |
|
I am struggling to understand how this is still a PR and hasn't been merged in the three years that it has been alive. If you're going to say:
Quiet. Don't forsake security in favor of upselling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to set instance metadata service (IMDS) access option to require the usage of tokens (IMDSv2). The default value, "optional", will not change the current behavior.