Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce retry mechanism #308

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Introduce retry mechanism #308

wants to merge 11 commits into from

Conversation

leochab
Copy link

@leochab leochab commented May 30, 2024

Context

When setting up checkers, some of them may return false positives for various reasons.

Solution

Create a retry mechanism for each checker.

  • If a checker does not need to trigger any notification, its behaviour remains unchanged.
  • If a checker would need to trigger a notification, we now:
    • Verify whether the checker should be retried. If so, relaunch it; otherwise, trigger the notification.
    • Each checker can be retried a maximum of three times.
    • If any of the retried job does not return any result, meaning it would not send any notification, stop the process.

Extra

Use this PR to update the required Ruby version and perform some code cleaning.

@leochab leochab self-assigned this May 30, 2024
@leochab leochab force-pushed the feature/update-checkers branch from b425b7f to 8c00246 Compare May 31, 2024 13:57
@leochab leochab changed the title Update ruby version and gems Introduce retry mechanism Jun 26, 2024
@leochab leochab force-pushed the feature/update-checkers branch from 8c00246 to 68c91c3 Compare June 26, 2024 15:34
@leochab leochab force-pushed the feature/update-checkers branch from 68c91c3 to 64814ec Compare June 26, 2024 15:55
@leochab leochab requested a review from watsonbox June 28, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant